eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.
MIT License
1.24k stars 170 forks source link

Unable to compile with catch 2.2.1 #133

Closed myrgy closed 5 years ago

myrgy commented 6 years ago

Hi,

Here is the error log when I'm trying to compile fakeit(master) with catch2 (master)

/home/user/Project/lib/fakeit/fakeit.hpp: In member function ‘void fakeit::CatchAdapter::fail(std::__cxx11::string, Catch::SourceLineInfo, std::__cxx11::string, std::__cxx11::string, Catch::ResultWas::OfType)’:
/home/user/Projects/rhino/engine/lib/fakeit/fakeit.hpp:1173:31: error: expected ‘{’ before ‘(’ token
             INTERNAL_CATCH_TRY( catchAssertionHandler ) { \
                               ^
/home/user/Project/lib/fakeit/fakeit.hpp:1173:31: error: expected ‘catch’ before ‘(’ token
/home/user/Project/lib/fakeit/fakeit.hpp:1173:33: error: ‘catchAssertionHandler’ does not name a type
             INTERNAL_CATCH_TRY( catchAssertionHandler ) { \
                                 ^~~~~~~~~~~~~~~~~~~~~
/home/user/Project/lib/fakeit/fakeit.hpp:1175:39: error: ‘class Catch::AssertionHandler’ has no member named ‘handle’; did you mean ‘handleExpr’?
                 catchAssertionHandler.handle( resultWas , fomattedMessage); \
                                       ^~~~~~
                                       handleExpr

Thank you!

vvvlc commented 6 years ago

myrgy/FakeIt fork works fine with Catch 2.2.2. Regards Vitek

myrgy commented 6 years ago

@vvvlc , that was you fix! Thanks a lot!

helmesjo commented 6 years ago

@eranpeer There seems to be a few issues related to catch2. Are there any plans to merge these patches in the near future?

myrgy commented 5 years ago

I think issue was fixed, hence closed.

vvvlc commented 5 years ago

I did not fix it I just found someone's branch that fixed it.

st 26. 9. 2018 v 15:19 odesílatel Alex Dalshov notifications@github.com napsal:

Closed #133 https://github.com/eranpeer/FakeIt/issues/133.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eranpeer/FakeIt/issues/133#event-1868386695, or mute the thread https://github.com/notifications/unsubscribe-auth/APHroOgI4oeJx01LEOmTT72qmd8LdJIbks5ue37NgaJpZM4TAT2u .

-- V.