search

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.
MIT License
1.24k stars 170 forks source link

Abstract classes, with virtual functions but no virtual destructors? #141

Closed mdmcgrath-ms closed 6 years ago

mdmcgrath-ms commented 6 years ago

There are 13 abstract classes in FakeIt, that do not have virtual destructors.

This throws an error on some platforms' compilers (e.g. XCode's compiler), because this isn't something people typically want. I understand that these compilers are not supported, per se, but would adding virtual destructors cause an issue?