Fix a GCC warning, and fix a crash under GCC when de-virtualization is enabled

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.

MIT License

1.23k stars 169 forks source link

Fix a GCC warning, and fix a crash under GCC when de-virtualization is enabled #186

Closed hedayat closed 3 years ago

hedayat commented 4 years ago

Fix a GCC warning about incompatible member function pointer cast
Disable de-virtualization in union_cast, which effectively prevents crashes when optimizaton is enabled under GCC when mocking classes with inline virtual dtor.

coveralls commented 4 years ago

Coverage remained the same at 99.923% when pulling 614c7851c6cc47b1149cab1a01f42aeb9705706e on hedayat:master into 814f28cd509ef2a8cdf7fe370bd9ec6d3b181dc7 on eranpeer:master.

hedayat commented 3 years ago

Created a new PR from an appropriate branch