catch v2.11.0 - Githubissues

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.

MIT License

1.24k stars 173 forks source link

catch v2.11.0 #195

Closed pgorgon-hem closed 3 years ago

pgorgon-hem commented 4 years ago

Updated catch2 port regarding to changes in catch2 v 2.11.0. Catch2 internal macros were changed and that changes are ported here as follows:

removed macro CATCH_INTERNAL_UNSUPPRESS_PARENTHESES_WARNINGS
added macros CATCH_INTERNAL_START_WARNINGS_SUPPRESSION and CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION

coveralls commented 4 years ago

Coverage remained the same at 99.923% when pulling 87884f5bf88e75b1f333256054abd4f2817d1537 on HEM-RnD:bugfix/catch_v2.11.0 into 814f28cd509ef2a8cdf7fe370bd9ec6d3b181dc7 on eranpeer:master.

josharenson commented 4 years ago

Am using master branch of FakeIt and Catch2. 4fb39c0bd36d5ea02c5f3f52afcc6192f0957ea8 makes it so I can compile. Thanks.

shrgabor commented 4 years ago

Why isn't this merged already? Can somebody clarify?

pgorgon-hem commented 4 years ago

Cute related changes should not be part of this request. Please remove them

Done. Cute related changes were in this branch because master was merged to our fork in wrong manner. I corrected it and cherrypicked commit with catch fixes from old branch. If someone is using previous commit than they should switch to new one because hash changed. I hope it will be available (means merged) into main repo in the near future.