Missing defines in single header for catch2

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.

MIT License

1.22k stars 170 forks source link

Missing defines in single header for catch2 #252

Closed poeschlr closed 2 years ago

poeschlr commented 2 years ago

Hi,

the defines CATCH_INTERNAL_START_WARNINGS_SUPPRESSION and CATCH_INTERNAL_STOP_WARNINGS_SUPPRESSION are not defined anywhere in https://github.com/eranpeer/FakeIt/blob/master/single_header/catch/fakeit.hpp#L1223. (I reverted it back to the old version for our local runs but i assume the proper fix would be to define these two macros)

Edit: the version of the header i looked at had version info: Generated: 2021-05-12 13:47:04.979584

FranckRJ commented 2 years ago

They are in catch2, not in fakeit.

https://github.com/catchorg/Catch2/blob/9ac8cad2d16e8f1a21db104672fe1ab26c872819/src/catch2/internal/catch_compiler_capabilities.hpp#L44

FranckRJ commented 2 years ago

FakeIt 2.1 improve support for older versions of catch2 (where these headers weren't available). So I guess your issue should be fixed.

FranckRJ commented 2 years ago

I'll close this issue as I guess it's fixed. If it's not the case you can reopen it.