search

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.
MIT License
1.22k stars 170 forks source link

Enable stubbing of move only return values. #282

Closed malcolmdavey closed 1 year ago

malcolmdavey commented 2 years ago

Implementation for this: https://github.com/eranpeer/FakeIt/issues/281

FranckRJ commented 2 years ago

Initializers in lambda captures is a feature of C++14, it should be changed to something that compile on strict C++11, like local classes if there's no other solution. You don't necessarily have to do it, I can do it myself when I'll merge this PR (this week I hope).

coveralls commented 2 years ago

Coverage Status

Coverage increased (+9.0e-05%) to 99.925% when pulling 1a734e402fc210c643d61b4e47b910d125ee741b on iress:OSS-7-allow-move-only-objects-for-return into 78ca536e6b32f11e2883d474719a447915e40005 on eranpeer:dev-2.3.1.

malcolmdavey commented 2 years ago

As with the other one - the move in the lambda is just an optimisation and not needed.

malcolmdavey commented 1 year ago

@FranckRJ Any chance of reviewing/approving this and the other PR - don't think there are any other active people on this repo to do it. Thanks.

malcolmdavey commented 1 year ago

Thanks @FranckRJ for approving