Enable compiling with Visual Studio 2019 v142

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.

MIT License

1.22k stars 170 forks source link

Enable compiling with Visual Studio 2019 v142 #290

Closed malcolmdavey closed 1 year ago

malcolmdavey commented 1 year ago

Not sure if this is the best approach, but Visual Studio 2019 (v142 toolset) complains about local class definitions which have pure virtual methods

compile switch to give std behaviour for __cplusplus macro
re-disable check which is not working for VS
disabled some constexpr that isn't working for windows.

coveralls commented 1 year ago

Coverage remained the same at 99.925% when pulling 6f4e97c228c64df3ca74510f3ad5a92a0b604e83 on iress:enable-build-and-test-vs2019-v142 into 78ca536e6b32f11e2883d474719a447915e40005 on eranpeer:master.

malcolmdavey commented 1 year ago

Fixing tests which have this issue for VS 2019 etc

error C3640: a referenced or virtual member function of a local class must be defined

https://github.com/eranpeer/FakeIt/issues/259

FranckRJ commented 1 year ago

Thanks for the fixes on VS, I usually only test with GCC / Clang (I don't really have a VS setup).