search

eranpeer / FakeIt

C++ mocking made easy. A simple yet very expressive, headers only library for c++ mocking.
MIT License
1.22k stars 170 forks source link

Disambiguate fakeit::Prototype<...>::MemberType parsing #299

Closed seva-deriv closed 1 year ago

seva-deriv commented 1 year ago

Add template keyword as required by C++ standard

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 99.925% when pulling 5a48e74dfbe80e54c2a905eecec25d92b94a3855 on seva-deriv:master into 96f193e884a9e5ae3af82903db3a81e595640bbb on eranpeer:dev-2.3.1.

FranckRJ commented 1 year ago

Thanks for the fix. Just out of curiosity, did you had any issue before adding that keyword, and if so with which compiler / what kind of code ?

And also, usually we don't change what's inside the single_header directory, it's only generated once before a release. If you can revert these changes it would be better but it's not a big deal anyway I can do it myself.

seva-deriv commented 1 year ago

OK, I'll revert. I faced the compilation error on clang/clang-cl 14.0.1. But the use case was not straightforward. It was in "disabled" context in expression like if constexpr (eval_to_false) { <HERE> }.