search

eraser-dev / eraser

🧹 Cleaning up images from Kubernetes nodes
https://eraser-dev.github.io/eraser/
Apache License 2.0
492 stars 62 forks source link

[BUG] Updating the wrong defaults in helm chart docs #1034

Closed akhilsaivenkata closed 5 months ago

akhilsaivenkata commented 5 months ago

What this PR does / why we need it: Updating the wrong defaults in helm chart docs

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #1032

Special notes for your reviewer:

sozercan commented 5 months ago

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

akhilsaivenkata commented 5 months ago

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

Sure @sozercan . I will do that and commit those changes.

akhilsaivenkata commented 5 months ago

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

@sozercan , I ran make manifests command and it has made changes to Readme.md in manifests_staging but it did not make any changes to values.yaml in manifests_staging, but I can see values.yaml in manifests_staging has already has our required changes.

I have pushed the new changes of Readme.md in manifests_staging. Is there anything I am missing here?

sozercan commented 5 months ago

@akhilsaivenkata all good, this is my bad. i meant readme here