Closed lzhecheng closed 3 weeks ago
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Files | Patch % | Lines |
---|---|---|
api/v1alpha3/zz_generated.deepcopy.go | 0.00% | 5 Missing :warning: |
api/v1alpha3/zz_generated.conversion.go | 0.00% | 2 Missing :warning: |
Flag | Coverage Δ | |
---|---|---|
unittests | 12.56% <0.00%> (-2.28%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
api/v1alpha3/eraserconfig_types.go | 55.93% <ø> (ø) |
|
api/v1alpha3/zz_generated.conversion.go | 0.62% <0.00%> (ø) |
|
api/v1alpha3/zz_generated.deepcopy.go | 0.00% <0.00%> (ø) |
@lzhecheng Thanks for updating! You can run goalngci-lint
in order to fix the lint test. It also looks like the collector pipeline test is failing. This tests deploying eraser with "make deploy" instead of helm, which is likely an issue in manifest_staging/charts/eraser/deploy/eraser.yaml
@lzhecheng Thanks for updating! You can run
goalngci-lint
in order to fix the lint test. It also looks like the collector pipeline test is failing. This tests deploying eraser with "make deploy" instead of helm, which is likely an issue inmanifest_staging/charts/eraser/deploy/eraser.yaml
You are right. Code updated. Is there a way I can start tests when I pushed?
@lzhecheng I am not sure why you are unable to run tests, I ran them again.
What this PR does / why we need it: Add fields for scanner volume mounts Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged): Fixes #996Special notes for your reviewer: