eraser-dev / eraser

🧹 Cleaning up images from Kubernetes nodes
https://eraser-dev.github.io/eraser/
Apache License 2.0
493 stars 62 forks source link

Contain CVE vulnerabilities of deleted images #888

Open CocoWang-wql opened 1 year ago

CocoWang-wql commented 1 year ago

We have customer feedback that to contain not only deleted image list but also the vulnerabilities of the deleted images in logs.

asifkd012020 commented 1 year ago

Hello Team, It would be great to see this feature enabled.

Thank you

sozercan commented 1 year ago

@asifkd012020 do you mind elaborating more on why are you looking for vuln details for deleted images?

or are you asking for #356 (vuln details on running images)?

asifkd012020 commented 1 year ago

Hello @sozercan, yes, we are looking for vuln details on running images for security and compliance requirements. We use Jfrog Artifactory to build images and its hard to get vul details(as in ACR).

Thank you.

sozercan commented 1 year ago

@asifkd012020 thanks! that is out of scope for eraser at this time, but we will consider it for future. we would recommend using https://aquasecurity.github.io/trivy-operator for this feature

asifkd012020 commented 1 year ago

@sozercan - We have airgapped environment and using Trivy operator is difficult option as mentioned in https://github.com/aquasecurity/trivy-operator/issues/1342 I would love this feature enabled through Eraser and customers won't have to build their own image and maintain it.

chen-keinan commented 1 year ago

@sozercan @asifkd012020 could you please elaborate how the integration with Eraser will look like ?

sozercan commented 1 year ago

@chen-keinan if this is re: #356, please comment in that issue

if your question is about this issue (cve details for deleted images), it is passing in CVE ID and adding to this line https://github.com/eraser-dev/eraser/blob/144e329ea046ab663d0dff37c04ba4ce888e117a/pkg/remover/helpers.go#L85