search

eraserhd / parinfer-rust

A Rust port of parinfer.
ISC License
546 stars 42 forks source link

Add an option to set additional filetypes to enable parinfer in for vim #107

Closed elkowar closed 6 months ago

elkowar commented 3 years ago

This PR adds an option to configure additional filetypes that parinfer should be active in. This allows the plugin to be used with any lisp, not just the ones explicitly specified in the plugin.

eraserhd commented 3 years ago

What filetypes do you need support for?

If it is a really obscure lisp, like something internal to an organization, then I'll merge this. Otherwise, I'd rather have the plugin detect it.

elkowar commented 3 years ago

my current usecase is yuck, a work-in-progress lisp-like language that will become the new configuration language for https://github.com/elkowar/eww

I'd of course love if that language was added to autodetect!

however, is there any reason not to still merge this? having the option of using parinfer in any WIP, obscure, or otherwise non-supported language seems like a pretty obvious benefit with no real drawbacks, or am I missing something?

eraserhd commented 3 years ago

In general, I want to avoid speculative features. Even small ones add up, I think.

In this particular case, this makes it easy to avoid adding languages to the plugin, which makes it more likely the plugin will not work out-of-the-box for common cases in the future.

I'd prefer to detect yuck, honestly.

elkowar commented 3 years ago

sure, in that case I'll spin up a PR to support yuck tomorrow 👍

hgouni commented 1 year ago

Hey, I have a pet lisp I'd like to use this on (https://github.com/hemantgouni/macaroni). Should I PR support for it, or is it better to merge this feature instead?