eraserhd / parinfer-rust

A Rust port of parinfer.
ISC License
546 stars 42 forks source link

Fix always smart mode when enabling via commands #60

Closed andreyorst closed 5 years ago

andreyorst commented 5 years ago

For some reason when %arg{1} is used in hooks it doe because it always empty for some reason when sent to function in a hook. I've changed that to a shell call to define hooks and now it works.

eraserhd commented 5 years ago

Merged.

Notes for the future:

I'd like to keep indentation more "regular" from now on - four spaces, not double-nesting, and indenting everything in brackets except for the module body. I'll do this later, since it'll help me understand how the code works now anyway.

I think we are past the point of needing a test harness for the Kakoune code. That's kind of a big undertaking, but I think I want that done before any more features. I'll look into that in a few days.

andreyorst commented 5 years ago

Notes for the future:

I'd like to keep indentation more "regular" from now on - four spaces, not double-nesting, and indenting everything in brackets except for the module body. I'll do this later, since it'll help me understand how the code works now anyway.

You can always tell me what you think should be rewritten or fixed, while pull request exists. I always welcome change requests.

eraserhd commented 5 years ago

@andreyorst Thanks, I will.

Apparently, I had added a few Kakoune tests, but they had bit rot. They are all fixed up and now running in CircleCI, along with Vim and Neovim tests.