search

erasmus-without-paper / ewp-specs-api-iias-approval

Specifications of EWP's Interinstitutional Agreements Approval API
MIT License
0 stars 0 forks source link

pdf size #4

Open spinho-uporto opened 1 year ago

spinho-uporto commented 1 year ago

Is there a maximum limit for delivering a pdf file?

I'm asking because XML Schema Validator (https://dev-registry.erasmuswithoutpaper.eu/schemaValidator) is returning "Result Failed Server error, try again. " when there is a large amount of data in pdf element. If I cut part of the data from pdf element, the validator returns "Result OK"

mkurzydlowski commented 1 year ago

There is no limit in the specification but probably some bug in the schema validator. We will look into that. Thank you!

mkurzydlowski commented 1 year ago

@spinho-uporto, can you attach the XML that resulted in the error?

umesh-qs commented 1 year ago

It is not a good design to not to impose a limit. A limit should be defined.

spinho-uporto commented 1 year ago

@spinho-uporto, can you attach the XML that resulted in the error?

It is not possible to put the XML here. The pdf is too big, maybe because it is digitally signed. File Info: MIME type: application/pdf; Size: 1.98 MB

The API is the "Interinstitutional Agreements Approval API". Here is an example without the pdf element, which I can not include here. 


<iias-approval-response
    xmlns="https://github.com/erasmus-without-paper/ewp-specs-api-iias-approval/tree/stable-v1"
    xmlns:xml="http://www.w3.org/XML/1998/namespace"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="
        https://github.com/erasmus-without-paper/ewp-specs-api-iias-approval/tree/stable-v1
        https://raw.githubusercontent.com/erasmus-without-paper/ewp-specs-api-iias-approval/master/response.xsd
    "
>
        <approval>
            <iia-id>9078046DB60B3BF5E0530B501E0A820D</iia-id>
            <conditions-hash>c8a40f6440c9dce36e6a3d9ac4dbb755dac5856c16112f41762a3cc6709cfef1</conditions-hash>
        </approval>
</iias-approval-response>
mkurzydlowski commented 1 year ago

It is not a good design to not to impose a limit. A limit should be defined.

@umesh-qs, what limit would you suggest? Should we all decide on a value that would suite everyone?

PS. EMREX has only this comment in the PDF attachment field's description.

umesh-qs commented 1 year ago

It is not a good design to not to impose a limit. A limit should be defined.

@umesh-qs, what limit would you suggest? Should we all decide on a value that would suite everyone?

PS. EMREX has only this comment in the PDF attachment field's description.

I would propose a limit of 10MB. But better take opinion from others as well.

janinamincer-daszkiewicz commented 1 year ago

I would propose a limit of 10MB. But better take opinion from others as well.

Any comments?

janinamincer-daszkiewicz commented 1 year ago

Recommendations please, wpp we won't be able to add this change to those planned for 6.3.0 or 7.0.0.