search

erasmus-without-paper / ewp-specs-api-iias

Specifications of EWP's Interinstitutional Agreements API.
MIT License
4 stars 13 forks source link

Stats when modifying mutually approved IIAs #154

Closed JoelBlancoCloserIdeas closed 9 months ago

JoelBlancoCloserIdeas commented 10 months ago

IIAs that are mutually approved and are being modified, should be considered as "iia-both-approved" or "iia-fetchable"?

In our opinion, it should be considered as "iia-both-approved" because it has already been approved, and we are just doing small changes to the agreement.

We should also consider that it's a new approval and at some point it will be approved by one partner and not by the other ("iia-local-approved-partner-unapproved" or "iia-local-unapproved-partner-approve").

janinamincer-daszkiewicz commented 10 months ago

Very good question. We designed stats endpoints long before we started talking about modifying mutually approved IIAs. Also we don't want to extend the set of the statistics. I have to think a while and consult the issue with the colleagues.

janinamincer-daszkiewicz commented 10 months ago

I think that from the business perspective the most important feature of such IIA is that it has been mutually approved and it will stay that way whatever happens in the future. Partners may start negotiations, but they will either revert or conclude so eventually this IIA will again be in the stable mutually approved state. Which means that we should report such IIA as both, feachable and mutually approved. Or saying in another way: for such IIA you should add 1 to the iia-fetchable counter and add 1 to the iia-both-approved counter . Does it make sense? P.S. Sets of iia-local-unapproved-partner-approved, iia-local-approved-partner-unapproved and iia-both-approved should be disjoint. Sets iia-local-unapproved-partner-approved, iia-local-approved-partner-unapproved and iia-both-approved should be subsets of iia-fetchable.

demilatof commented 10 months ago

Therefore, we could say that "iia-fetchable" is the number of IIA IDs we provide with Index API? And "iia-both-approved" could be read as: we have XX IIAs "iia-fetchable", of which YY are "iia-both-approved"? (with XX>=YY)

janinamincer-daszkiewicz commented 10 months ago

Therefore, we could say that "iia-fetchable" is the number of IIA IDs we provide with Index API? And "iia-both-approved" could be read as: we have XX IIAs "iia-fetchable", of which YY are "iia-both-approved"? (with XX>=YY)

Yes