erasmus-without-paper / ewp-specs-api-iias

Specifications of EWP's Interinstitutional Agreements API.
MIT License
4 stars 13 forks source link

Clarifying `valid-for-approval` XSLT output element #156

Closed mkurzydlowski closed 7 months ago

mkurzydlowski commented 8 months ago

Answering an issue that was brought up during the last Infrastructure Forum meeting, I have created a change proposal to clarify valid-for-approval element that is part of the XSLT output. Please review it.

janinamincer-daszkiewicz commented 8 months ago

We were wondering locally in the team whether it is worth keeping the attribute or getting rid of it. The prevailing opinion was that it does not cause any additional burden for programmers (it is generated by XSLT), and that it carries some additional information that the programmer may or may not use in the local implementation.

XSLT generates the result without knowing whether IIA is mutually approved. The presence of the attribute means that IIA misses some values which are required in IIA v7 and should be accepted by a user. It could be used, for example, in the interface to alert end users.

All in all we decided to keep the attribute but to better explain its role. See the proposal by Michał.

Answering the question raised by Luis during the last meeting - after you generate with XSLT-v7 and you get you can:

mkurzydlowski commented 7 months ago

Change proposal (#155) has been merged.