search

erasmus-without-paper / ewp-specs-api-institutions

Specifications of EWP's Institutions API.
MIT License
0 stars 0 forks source link

Which language code standard do we use? #11

Closed lennertVanSever closed 6 years ago

lennertVanSever commented 6 years ago

I have been looking for a while which language code standard we use. I assume that we use ISO 639-1? I hope that I don't waste anyone their time by asking this but I couldn't find it in the documentation.

lennertVanSever commented 6 years ago

To a further extent, I'm also wondering which Alphabet code we are using? (from the example: ru-Cyrl)

MartaJuzepczuk commented 6 years ago

Which element are you asking about? StringWithOptionalLang,MultilineStringWithOptionalLang and HTTPWithOptionalLang are explained here: https://github.com/erasmus-without-paper/ewp-specs-architecture/blob/stable-v1/common-types.xsd. All of them refer to xs:language type.

janinamincer-daszkiewicz commented 6 years ago

Lennert, is this clear now or do you expect further explanations?

lennertVanSever commented 6 years ago

Well the common type XML still doesn't specify which languagecode ISO is used. I assume we use ISO 639-1 since this is often used as language code.

MartaJuzepczuk commented 6 years ago

There was an idea to require ISO 639-1 (see this issue), but it was rejected (the same issue). As I remember, we don't specify anything more than the tag documentation.

Actually, in our implementation we also send ISO 639-1 codes (without any extensions) and when receiving, we compare the beginning of the answer with ISO 639-1. I think that for practical use it is enough.

lennertVanSever commented 6 years ago

Okay this is clear for me, thanks for the responses :)