erasmus-without-paper / ewp-specs-api-institutions

Specifications of EWP's Institutions API.
MIT License
0 stars 0 forks source link

Ability to identify unique contacts #12

Closed umesh-qs closed 4 years ago

umesh-qs commented 5 years ago

Is there any reason why contacts are not given a unique id similar to iia_id in IIA api? If we can have a unique id then it can be used in IIA api as well.

MartaJuzepczuk commented 5 years ago

You would like to have Contacts API?

umesh-qs commented 5 years ago

Not really. In institutions API we have below section. A unique id can be given here

IRO Office iro@uio.no
MartaJuzepczuk commented 5 years ago

If you receive such an id in IIAs response and you do not have the Contacts API, than you have to call institutions API and search ids on your own. Does not seem convenient.

umesh-qs commented 5 years ago

I am not sure if I have understood your comment. If we can have something like below. Since IIA contact is an institution/ounit contact, Id:ASADENKVFFFJHJJ can be sent in IIA API. Other contact info need not be passed and mapping becomes easier

ASADENKVFFFJHJJ IRO Office iro@uio.no
MartaJuzepczuk commented 5 years ago

Since IIA contact is an institution/ounit contact

Maybe, but I'm not sure.

Other contact info need not be passed and mapping becomes easier

You are right. But if I get an IIAs response and see <c:contact-id>ASADENKVFFFJHJJ</c:contact-id> than what should I do?

umesh-qs commented 5 years ago

If contact-id is there then you can sync the partner contacts without any confusion. In IIA if partner contact-id is there then you can easily map signing contact and the agreement contact coming from partner, since they would already have been mapped at the time of institution/ounit import

MartaJuzepczuk commented 5 years ago

Let's wait for the opinion of the other network users @erasmus-without-paper/all-members

wrygiel commented 5 years ago

There has been a draft proposal of introducing unique person identifiers. It has been abandoned, because there seemed to be no need for such (at the time it has been proposed), and making these identifiers really unique was tricky (especially for some edge cases, like multiple nationalities).

You can still find this proposal in a sperate GitHub repository (it's no longer linked at the developers page, I believe).

(Sorry for not pasting a link, but I'm writing this on a plane. Will do that later on if you don't find it.)

On Thu, Aug 1, 2019, 10:16 Marta Juzepczuk notifications@github.com wrote:

Let's wait for the opinion of the other network users @erasmus-without-paper/all-members https://github.com/orgs/erasmus-without-paper/teams/all-members

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/erasmus-without-paper/ewp-specs-api-institutions/issues/12?email_source=notifications&email_token=AAQRNV6RLBMMDYNQ7XUHV4LQCKLVZA5CNFSM4IIFLJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3JX5YQ#issuecomment-517177058, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQRNV36HYAJZBOQCTSON4DQCKLVZANCNFSM4IIFLJEQ .

umesh-qs commented 5 years ago

I am not sure what person mean here. I am referring to only contacts of Institution. Every institution should have a unique id in their system database in the same way as they have a unique id for an IIA.

wrygiel commented 5 years ago

Sorry, I misunderstood. Ignore my comment then.

EvelienRenders commented 4 years ago

Perhaps replying to this now is not relevant anymore, but I'm very curious if this discussion was continued somewhere, or if it has been abandoned. If the latter, the issue can be closed. If the former, I'm curious what became of it, because if I understand correctly there is no way to manage 'contacts' separate from the IIA's right now? It would be lovely if the contacts that HEI's register in the ErasmusDashboard/other system, would be shared via EWP, so we can keep our CRM up-to-date via that API.

@umesh-qs @wrygiel @MartaJuzepczuk

janinamincer-daszkiewicz commented 4 years ago

No, the discussion has not been continued. It seems that nobody (but Umesh) at that time has been interested in strong and unique identification of contacts.