Inconsistencies in get-response.xsd's latest-changes and latest-proposal

[j-be]

After looking at https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/master/endpoints/get-response.xsd for quite some time I noticed ~two~ three inconsistencies.

The first one seems to be a typo in <xs:element name="latest-changes" ...'s xs:documentation:

• is: ...and here we can see changes compared to the "last-approved"
• I think should be: ... "latest-approved"

The second one ist the definition of <xs:element name="latest-proposal"

• minOccurs="1" contradicts xs:documentation which says "If there are no proposals of change to the latest approved version, this element will not be present"
• "It contains courses planned to be studied with changes compared to the "before-mobility". After acceptance it will be copied to the "latest-approved" section. If there are no proposals of change to the latest approved version, this element will not be present."

EDIT: The third one is the documentation of the unnamed element containing before-mobility and latest-approved:

The "before mobility" and "latest approved" sections are optional - this indicates that no LA has yet been approved. However, if "before mobility" section exists, then we also require "latest approved" section to exist.`

contradicts with both of them being minOccurs="1" maxOccurs="1". I would propose to change the documentation to:

The "before mobility" and "latest approved" sections are optional - this indicates that no LA has yet been approved. However, if either of the two sections exists, then we also require the other section to exist."

[kamil-olszewski-uw]

Your comments relate to the "master" branch, which reflects the LAs of the old Erasmus + program.

The latest version of the API, still unofficial and almost ready (we are working on the final touches), can be found in the "new-la-template" branch, which will soon be transformed into a new official API version:

https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/new-la-template/endpoints/get-response.xsd

Changing the branch in GitHub is possible using the button in the upper left corner.

The things you describe no longer apply to this new branch.

However, responding to your comments:

(1) You are right about the "last-approved" typo. (2) Indeed, the items you have listed are mandatory (minOccurs = "1"). But please note that those items are inside optional sequences.

[j-be]

Oh, that is unfortunate. From @janinamincer-daszkiewicz comments on #9 I somehow deduced, that master is "kind of stable". I must have misinterpreted.

There are still open points in #9 though, so should you have some spare time I would appreciate any new insight. :smiley: