erasmus-without-paper / ewp-specs-api-omobility-las

Learning Agreements
MIT License
1 stars 2 forks source link

Inconsistencies in update-request on branch new-la-template #11

Closed j-be closed 3 years ago

j-be commented 3 years ago

It says "Servers publish the list of supported update in their manifest entry.", but https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/new-la-template/manifest-entry.xsd does not offer this functionality anymore.

In general, I would propose reverting the changes to manifest-entry.xsd and bring back supported-update-types. I see it as necessary for the -v1, -v2 etc. update types still described in https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/new-la-template/endpoints/update.md. Else, a client has simply no way to find out which update types are actually supported by the current server implementation.

Also, the very commit removing the section from manifest-entry.xml (https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/commit/cc59495f65a0497e8766439d741e76e3b2ecf509) is misleading as it says "All update request types should be supported by the server", but it now reads as "All update request types MUST be supported by the server".

mkurzydlowski commented 3 years ago

You are right, the comment should use "must" as that was the intention in the change.

So the "Servers publish the list of supported update in their manifest entry" sentence should be removed.

Do you have further comments concerning this before I correct the documentation?

j-be commented 3 years ago

Yes. With this change the whole -v1, -v2 is not usable in practice: