deleted ids and modified scenario 2

erasmus-without-paper / ewp-specs-api-omobility-las

Learning Agreements

MIT License

1 stars 2 forks source link

deleted ids and modified scenario 2 #29

Closed saouling closed 3 years ago

saouling commented 3 years ago

deleted ids where not necessary
modified scenario 2 (PDFs and src files)

kamil-olszewski-uw commented 3 years ago

Don't you want to merge the changes to README.md this time?

kkaraogl commented 3 years ago

There aren't any.

Have you taken a look at the modified Scenario 2? Do you think it clears up the confusion?

kamil-olszewski-uw commented 3 years ago

I got a little lost. There were changes to README.md in your request that you closed today:

https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/pull/25

Where have these changes gone?

Scenario 2 itself is ok now. But there is still Ex 6 present (not related to any scenario now, unless I missed something) that contains invalid LAs without any set of components. There was a question about this example on GitHub today.

kkaraogl commented 3 years ago

By mistake Nikos sent them. These changes were already merged.

kamil-olszewski-uw commented 3 years ago

Ok. So we just have to solve the Ex 6 issue.

kkaraogl commented 3 years ago

We'll replace the Ex 6 with an empty response, so that enumeration stays consistent, and open a pull request asap.

Would you consider merging this one, since no scenario is actually referencing the Ex 6 response now, and there are questions popping up about it?