search

erasmus-without-paper / ewp-specs-api-omobility-las

Learning Agreements
MIT License
1 stars 2 forks source link

Elements approved-changes and changes-proposal to the first-version of LA #39

Closed spinho-uporto closed 1 year ago

spinho-uporto commented 1 year ago

In elements approved-changes and changes-proposal there is an indication that the changes are to the first-version. https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/stable-v1/endpoints/get-response.xsd#L201 https://github.com/erasmus-without-paper/ewp-specs-api-omobility-las/blob/stable-v1/endpoints/get-response.xsd#L210

How to deal with the foolowing scenario:

  1. fist version has component A
  2. approved-changes deletes component A and inserts component B
  3. component A is intended to be inserted and component B to be deleted with a changes-proposal

The last changes-proposal (in 3.) puts the list of components equals to the first version - there are no changes to the first version. There is no possible to delete the approved-changes that change the first version (in 2.). What to do in this situation?

kamil-olszewski-uw commented 1 year ago

If component A reintroduced in version 3 is identical to component A in version 1, you have to send LA with empty (but existing) changes-proposal section in version 3. After approval, it will look like component A was never removed and component B never existed in LA.

It may look a bit strange, but that's how the LA template was defined.