erasmus-without-paper / ewp-specs-api-omobility-las

Learning Agreements
MIT License
1 stars 2 forks source link

The partner has switched to a new provider and has sent Learning Agreements that were in the First Version. #49

Open anant6767 opened 1 week ago

anant6767 commented 1 week ago

We have a case where the partner changed providers and then sent us the LA from First version onwards i.e. no changes proposal was present. Is this acceptable? Can they continue to make changes post the first version?

<la:la>
    <la:omobility-id>1GEC7T6I-303P-PH1R-1IEW-9RJE1U2H4ROK</la:omobility-id>
    <la:sending-hei>
      <la:hei-id>xxxxxxxxxxxx</la:hei-id>
      <la:ounit-name>xxxxx </la:ounit-name>
      <la:ounit-id>XXXXX</la:ounit-id>
      <la:contact-person>
        <la:given-names>Kanchana28</la:given-names>
        <la:family-name>28test</la:family-name>
        <la:email>hebib94303@jwsuns.com</la:email>
        <p:phone-number>
          <p:other-format>235</p:other-format>
        </p:phone-number>
      </la:contact-person>
    </la:sending-hei>
    <la:receiving-hei>
      <la:hei-id>yyyyyyyyyyyyy</la:hei-id>
      <la:contact-person>
        <la:given-names>10909NeverInternalContactFN</la:given-names>
        <la:family-name>10909NeverInternalContactLN</la:family-name>
        <la:email>neverewo123@yopamil.com</la:email>
        <p:phone-number>
          <p:other-format>876543</p:other-format>
        </p:phone-number>
      </la:contact-person>
    </la:receiving-hei>
    <la:receiving-academic-year-id>2027/2028</la:receiving-academic-year-id>
    <la:student>
      <la:given-names>values</la:given-names>
      <la:family-name>blank</la:family-name>
      <la:global-id>esitest1212</la:global-id>
      <la:birth-date>1995-05-08</la:birth-date>
      <la:citizenship>AD</la:citizenship>
      <la:gender>1</la:gender>
      <la:email>hanifoci@mailinator.com</la:email>
    </la:student>
    <la:start-date>2024-05-20</la:start-date>
    <la:end-date>2024-09-25</la:end-date>
    <la:eqf-level-studied-at-departure>3</la:eqf-level-studied-at-departure>
    <la:isced-f-code>0031</la:isced-f-code>
    <la:student-language-skill>
      <la:language>BM</la:language>
      <la:cefr-level>B1</la:cefr-level>
    </la:student-language-skill>
    <la:first-version>
      <la:components-studied>
        <la:component>
          <la:los-code>values1</la:los-code>
          <la:title>code</la:title>
          <la:term-id>
            <trm:term-number>2</trm:term-number>
            <trm:total-terms>2</trm:total-terms>
          </la:term-id>
          <la:credit>
            <la:scheme>ects</la:scheme>
            <la:value>0.0</la:value>
          </la:credit>
          <la:short-description>updated descripion</la:short-description>
        </la:component>
      </la:components-studied>
      <la:student-signature>
        <la:timestamp>2024-05-09T11:53:41+00:00</la:timestamp>
        <la:signer-app>Provider1</la:signer-app>
      </la:student-signature>
      <la:sending-hei-signature>
        <la:signer-name>Test</la:signer-name>
        <la:signer-position>ms</la:signer-position>
        <la:signer-email>nanette@yopmail.com</la:signer-email>
        <la:timestamp>2024-05-09T11:45:44+00:00</la:timestamp>
        <la:signer-app>Provider1</la:signer-app>
      </la:sending-hei-signature>
      <la:receiving-hei-signature>
        <la:signer-name>Test </la:signer-name>
        <la:signer-position>tmkoc</la:signer-position>
        <la:signer-email>sudeshna@qs.com</la:signer-email>
        <la:timestamp>2024-05-09T11:54:36+00:00</la:timestamp>
        <la:signer-app>Provider1</la:signer-app>
      </la:receiving-hei-signature>
    </la:first-version>
  </la:la>

Steps

Question: Can Provider 2 assume that the LA is valid since they do not have the original approval or history? Question 2: Can this LA be further edited i.e. post first version? Since the sending institution has not changed their provider, they should not have any problems in updating their LA.

janinamincer-daszkiewicz commented 1 week ago

Thank you Anant for creating this issue. Could you please upload here the last version of LA created under the old provider and the first one created under the new provider (of course with anonymised private data). In particular I would like to see which identifiers are reused which allow to recognize this LA as the old one.

anant6767 commented 1 week ago

Thank you Anant for creating this issue. Could you please upload here the last version of LA created under the old provider and the first one created under the new provider (of course with anonymised private data). In particular I would like to see which identifiers are reused which allow to recognize this LA as the old one.

Updated the question with example, steps and questions

janinamincer-daszkiewicz commented 6 days ago

Question: Can Provider 2 assume that the LA is valid since they do not have the original approval or history?

Yes. This LA has all three signatures from proper persons. Provider does not matter (from the business point of view).

Question 2: Can this LA be further edited i.e. post first version? Since the sending institution has not changed their provider, they should not have any problems in updating their LA.

Yes, it can.

anant6767 commented 6 days ago

but Provider2 will not have any history of the action taken on learning agreement.

janinamincer-daszkiewicz commented 6 days ago

That's true, but will this be a problem? Can you show an example when this will matter.

anant6767 commented 17 hours ago

How to the receiver knows that the LA received is genuine ?

janinamincer-daszkiewicz commented 15 hours ago

Because it comes from the server covering the sending hEI.

umesh-qs commented 15 hours ago

What Anant meant is the genuineness of the receiver signature added on the LA by the sending HEI.

janinamincer-daszkiewicz commented 14 hours ago

I understand that you mean this part of LA:

    <la:first-version>
      (..)
      <la:receiving-hei-signature>
        <la:signer-name>Test </la:signer-name>
        <la:signer-position>tmkoc</la:signer-position>
        <la:signer-email>sudeshna@qs.com</la:signer-email>
        <la:timestamp>2024-05-09T11:54:36+00:00</la:timestamp>
        <la:signer-app>Provider1</la:signer-app>
      </la:receiving-hei-signature>
    </la:first-version>

'signer-app' where the name of the Provider is given has no business value. If HEI get LA from the proper node, with the proper signer name, position, email, it can assume that this is the valid LA, the same as the one obtained from the other provider. In particular 'signer-app' is optional. In fact it would be interesting to know if any node processes this field in any way.