onlyPayloadSize should not be necessary with Solidity 0.5

erasureprotocol / erasure-protocol

Information wants to be expensive

https://erasure.world/

MIT License

164 stars 27 forks source link

onlyPayloadSize should not be necessary with Solidity 0.5 #277

Open fulldecent opened 4 years ago

fulldecent commented 4 years ago

I learned the hard way that Solidity has stronger type safety. Because it broke the ERC-165 reference implementation. The function onlyPayloadSize seems to be testing for something that Solidity now automatically tests for.

Recommendation: review if onlyPayloadSize is necessary.

References:

Definition: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/helpers/mock/MockNMR.sol#L21

thegostep commented 4 years ago

Mock NMR should really be compiled with solc 0.4.11 in order to match the deployed token https://etherscan.io/address/0x1776e1f26f98b1a5df9cd347953a26dd3cb46671#code

Future improvement will be to modify compilation script to support multiple solidity versions