💣 Griefing RatioType is not type safe, improper decoding

[fulldecent]

Griefing.RatioType is defined as an enum.

enum RatioType { NaN, Inf, Dec }

Some usage is correct per the ABI but is not type safe.

struct AgreementParams {
    uint120 ratio;
    uint8 ratioType;
    uint128 countdownLength;
}

Additionally this can lead to incorrect decoding of transaction data.

... abi.decode(agreementParams, (uint256, uint8, uint256));

Best practice is to use safe types when they are defined.

Recommendation: use safe types, correct incorrect type usage

Additional notes:

Reference:

• Definition: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/modules/Griefing.sol#L14
• Unsafe usage: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/escrows/CountdownGriefingEscrow.sol#L35
• Unsafe usage: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/escrows/CountdownGriefingEscrow.sol#L112
• Improper decoding: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/escrows/CountdownGriefingEscrow.sol#L114
• Incorrect type documentation: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/agreements/CountdownGriefing.sol#L34