erasureprotocol / erasure-protocol

Information wants to be expensive
https://erasure.world/
MIT License
164 stars 27 forks source link

isCreator can be removed from API surface #285

Closed fulldecent closed 4 years ago

fulldecent commented 4 years ago

This function provides limited utility to the public, since getCreator is already available.

Also, every use of isCreator is from a subclass checking for access control and those subclasses are all Operated.

Recommendation: consider to have Template subclass from Operated and charge isCreator from a public function into an internal modifier.

References:

thegostep commented 4 years ago

Keeping Template separate but changing isCreator to internal