⚠️ Mint / burn should be explained clearly - Githubissues

erasureprotocol / erasure-protocol

Information wants to be expensive

https://erasure.world/

MIT License

164 stars 27 forks source link

⚠️ Mint / burn should be explained clearly #293

Closed fulldecent closed 4 years ago

fulldecent commented 4 years ago

The Numerai token includes that the intricacy that the burn function is named mint.

Failing to clearly explain an unintuitive interface can lead to improper function calls.

Recommendations: clearly explained this in the iNMR interface.

References:

Intricacy is used but not explained: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/modules/iNMR.sol#L17
Intricacy defined: https://etherscan.io/address/0x1776e1F26f98b1A5dF9cD347953a26dd3Cb46671#code // https://etherscan.io/address/0x29f709e42c95c604ba76e73316d325077f8eb7b2#code