search

erayalakese / slack-wordpress

WordPress Integration for Slack
MIT License
43 stars 12 forks source link

Add Icon #5

Closed wormeyman closed 9 years ago

wormeyman commented 9 years ago

Using Font Awesome House icon like slack. This shouldn't conflict with their branding hopefully.

erayalakese commented 9 years ago

@wormeyman ,

I'm really happy about your helps for this plugin. Thank you.

This shouldn't conflict with their branding hopefully.

You're using Font-Awesome so it's not about Slack. I just look for Font-Awesome's license and here the message about license :

image

wormeyman commented 9 years ago

:+1: I'm glad I could help.

erayalakese commented 9 years ago

@wormeyman Can you tell me where this icon will appear?

wormeyman commented 9 years ago

image

It'll go there when people search.

erayalakese commented 9 years ago

Hello @wormeyman ,

I was waiting for answer from Slack developers to use their logo . Because of this I couldn't merge this PR . But thank you for your effort.

wormeyman commented 9 years ago

Did they say yes?

erayalakese commented 9 years ago

Not yet :) I'll keep this issue open until I got an answer.

wormeyman commented 9 years ago

That would be great if you could :smiley:

erayalakese commented 9 years ago

Hello @wormeyman ,

If you want to support this plugin on wordpress.org can you please give a review ?

Thank you.

erayalakese commented 9 years ago

I've uploaded Slack's icon ., you can see it on search page.

Thank you for patch !