search

erc6551 / reference

ERC-6551 reference implementation
152 stars 50 forks source link

createAccount params change #27

Closed zapaz closed 11 months ago

zapaz commented 11 months ago

createAccount params have changed in https://github.com/erc6551/reference/blob/main/src/ERC6551Registry.sol

    function createAccount(
        address implementation,
        bytes32 salt,
        uint256 chainId,
        address tokenContract,
        uint256 tokenId
    ) external returns (address) {

and is no more compliant to ERC6551 EIP https://eips.ethereum.org/EIPS/eip-6551

    function createAccount(
        address implementation,
        uint256 chainId,
        address tokenContract,
        uint256 tokenId,
        uint256 salt,
        bytes calldata initData
    ) external returns (address);

both should be the same ?

jaydenwindle commented 11 months ago

@zapaz This repo is upstream of the EIP, so changes will appear here before they are merged into the EIP. The PR to update the EIP to match the interface in this repo is here.

zapaz commented 11 months ago

@zapaz This repo is upstream of the EIP, so changes will appear here before they are merged into the EIP. The PR to update the EIP to match the interface in this repo is here.

perfect, moreover changes have been merged to the EIP now