search

ercanserteli / condenser

Condenser allows you to extract speech audio from video files, based on subtitle timings. By omitting the audio outside of speech, it increases the language per second that you are getting exposed to.
https://ercanserteli.com/condenser
GNU General Public License v3.0
33 stars 7 forks source link

Can't choose external subs if video file has embedded subs? #4

Closed DiogoAirtonLameiro closed 2 years ago

DiogoAirtonLameiro commented 2 years ago

If a video file has multiple embedded subs, but I want external subs to be used to target the audio, the "multiple subs detected" popup seems to only list the embedded subs, is it possible to fix this?

ercanserteli commented 2 years ago

Normally if you have external subs, even if you set the config "ask_when_multiple_srt" to true, it should still automatically use the external file without asking (assumes you always want the external file). It seems this doesn't work as it should if you run it on a folder, asks you to select an internal subtitle. Thanks for the report.

DiogoAirtonLameiro commented 2 years ago

No problem! Do you happen to have a rough ETA on when it'll be fixed?

ercanserteli commented 2 years ago

Hopefully fixed in d270ee5 with the new version v1.3.0

DiogoAirtonLameiro commented 2 years ago

Nice, I'll check it out and report in

DiogoAirtonLameiro commented 2 years ago

Yep, seems to be working properly, nice!