mpg/inflow - Githubissues

erdc / RAPIDpy

RAPIDpy is a python interface for RAPID that assists to prepare inputs, runs the RAPID program, and provides post-processing utilities.

BSD 3-Clause "New" or "Revised" License

23 stars 26 forks source link

mpg/inflow #56

Closed mgeheran closed 3 years ago

mgeheran commented 3 years ago

This is integrates recent changes on master with mjshaw's inflow updates.

mgeheran commented 3 years ago

@mjshaw1 I made a few modifications that mostly deal with naming conventions. Please let me know if there is any functionality that I left out. The reservoir routing parameters for RAPID are up next.

mgeheran commented 3 years ago

Hello, @mjshaw1. Thank you for reviewing. We each took a different approach to handling the ECMWF netCDF variable names, but the functionality should be equivalent. As far as testing goes, I have tested the cases for which we currently have data on the repository. If you are aware of any new cases that are not properly handled, we need to address that.

mgeheran commented 3 years ago

@mjshaw1 with respect to the other issues you mentioned:

JULES is consistently misspelled throughout the repository. I think this is low priority.
I resisted combining ERA Interim and ERA5 functionality into the same subclass to keep them logically separated. I believe this potentially simplifies the debugging process.
A standard runoff input format would certainly make our workflow more efficient. I agree that we should consider this option.