search

erdc / air-water-vv

Verification and validation tests for computational models of air/water flow
MIT License
5 stars 14 forks source link

Ventilation problem on weirs. #154

Open lmaurel opened 7 years ago

lmaurel commented 7 years ago

I turned off the air ventilation of the broad crested weir of lmaurel/general_update_review branch (https://github.com/erdc-cm/air-water-vv/tree/lmaurel/general_update_review/2d/hydraulicStructures/broad_crested_weir) and of the sharp crested weir (https://github.com/erdc-cm/air-water-vv/tree/lmaurel/general_update_review/2d/hydraulicStructures/sharp_crested_weir) because (as you might know) the calculation crashes when the water reaches the ventilation. We were talking about this problem few months ago and I don't know if someone has solved this problem ? If not, we still can run these cases by setting air_vent to False in the context options like I did.

adimako commented 7 years ago

@cekees, we were just wondering if this has been solved. If not we can put it in air-water-vv with the patch closed and keep the issue open

cekees commented 7 years ago

Thanks. I'll have to take a look at it. @lmaurel what exactly is crashing? E.g. is it the Newton solver for the navier-stokes step failing to converge or something else?

lmaurel commented 7 years ago

@cekees - The case is not crashing anymore but when the water get closer to the ventilation there is a problem as you can see in the following GIF. I might be a boundary condition problem at the air ventilation. ventilation_problem_bcweir

adimako commented 7 years ago

It looks like the water reaching there triggers some kind of jet blast :)

cekees commented 7 years ago

That's an exciting failure! I can reproduce so at least we have something to work with. I suspect it has something to do with the pressure boundary condition at the vent.

adimako commented 7 years ago

It is a bit puzzling, because this one fails but the outlet which is the same bc does not. Maybe the way the nodes are assigned to patches?

We should aim to create a gallery with impressive failures