erdc / proteus

A computational methods and simulation toolkit
http://proteustoolkit.org
MIT License
88 stars 56 forks source link

Pugged ArgumentsDict into RANS2P_IB #1155

Closed JohanMabille closed 4 years ago

JohanMabille commented 4 years ago

Mandatory Checklist

Please ensure that the following criteria are met:

As a general rule of thumb, try to follow PEP8 guidelines.

Description

JohanMabille commented 4 years ago

The method calculateForce and calculateVelocityAverage are never called in the Python file.

codecov[bot] commented 4 years ago

Codecov Report

Merging #1155 into master will decrease coverage by 0.13%. The diff coverage is 40.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   51.63%   51.50%   -0.14%     
==========================================
  Files         539      540       +1     
  Lines      102272   103941    +1669     
==========================================
+ Hits        52805    53530     +725     
- Misses      49467    50411     +944     
Impacted Files Coverage Δ
proteus/WaveTools.py 0.00% <0.00%> (ø)
proteus/config/copper.py 0.00% <ø> (ø)
proteus/mprans/RANS2P_IB.py 0.00% <0.00%> (ø)
proteus/mprans/RANS3PSed.py 0.00% <0.00%> (ø)
proteus/mprans/VOS3P.py 0.00% <0.00%> (ø)
proteus/mprans/Dissipation.py 11.87% <12.50%> (+0.41%) :arrow_up:
proteus/mprans/Kappa.py 11.73% <12.50%> (+0.27%) :arrow_up:
...sts/solver_tests_mprans/import_modules/cavity2d.py 66.18% <25.00%> (ø)
proteus/tests/griffiths_lane_6/sm_gl_6_3d_n.py 94.73% <50.00%> (-5.27%) :arrow_down:
proteus/tests/griffiths_lane_6/sm_gl_6_3d_p.py 71.87% <50.00%> (-0.74%) :arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13b2dd8...e0ed682. Read the comment docs.