JohanMabille commented 4 years ago

Mandatory Checklist

Please ensure that the following criteria are met:

[ ] Title of pull request describes the changes/features
[ ] Request at least 2 reviewers
[ ] If new files are being added, the files are no larger than 100kB. Post the file sizes.
[ ] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
[ ] New features have appropriate documentation strings (readable by sphinx)
[ ] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

JohanMabille commented 4 years ago

The methods "getTwoPhasesXXX" are never called in the Python file.

cekees commented 4 years ago

The methods "getTwoPhasesXXX" are never called in the Python file.

They're called in the solvers: https://github.com/erdc/proteus/blob/master/proteus/LinearSolvers.py#L3482

Once you finish this, I may look at creating a separate class for those functions, but for now I'd like to leave them there.

JohanMabille commented 4 years ago

Thanks for the pointer, I need to fix the linear solvers then.

JohanMabille commented 4 years ago

Theoretically it should, since it is where the python interface of arguments_dict is defined. I can make a pass on setup.py to clean it once we're done with the migration.

cekees commented 4 years ago

Made these changes and fixed other issues in #1163

JohanMabille commented 4 years ago

Thanks! I will go on with the remaining files tonight.

erdc / proteus

Plugged ArgumentsDict into RANS2P #1156

Mandatory Checklist

Description