erdc / proteus

A computational methods and simulation toolkit
http://proteustoolkit.org
MIT License
88 stars 56 forks source link

Make consistent use of 'ncls' instead of 'phi' for ic/bc in TwoPhaseFlow app #1158

Closed cekees closed 4 years ago

cekees commented 4 years ago

Mandatory Checklist

Please ensure that the following criteria are met:

As a general rule of thumb, try to follow PEP8 guidelines.

Description

codecov[bot] commented 4 years ago

Codecov Report

Merging #1158 into master will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   51.76%   51.76%   -0.01%     
==========================================
  Files         540      540              
  Lines      103400   103400              
==========================================
- Hits        53530    53529       -1     
- Misses      49870    49871       +1     
Impacted Files Coverage Δ
proteus/TwoPhaseFlow/utils/Parameters.py 79.26% <0.00%> (ø)
proteus/tests/test_boundaryconditions.py 97.33% <0.00%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66b6701...75e6547. Read the comment docs.

jhcollins commented 4 years ago

I feel like I've fixed this in a pr like 3 other times. weird