Closed jhcollins closed 4 years ago
Merging #1213 into master will increase coverage by
1.21%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
+ Coverage 50.87% 52.09% +1.21%
==========================================
Files 526 526
Lines 108803 108803
==========================================
+ Hits 55358 56681 +1323
+ Misses 53445 52122 -1323
Impacted Files | Coverage Δ | |
---|---|---|
proteus/tests/test_boundaryconditions.py | 97.21% <0.00%> (-0.37%) |
:arrow_down: |
proteus/NumericalFlux.py | 42.80% <0.00%> (+0.05%) |
:arrow_up: |
proteus/mprans/NCLS.py | 73.97% <0.00%> (+0.09%) |
:arrow_up: |
proteus/mprans/MCorr.py | 51.53% <0.00%> (+0.09%) |
:arrow_up: |
proteus/mprans/RDLS.py | 66.98% <0.00%> (+0.10%) |
:arrow_up: |
proteus/mprans/VOF.py | 85.58% <0.00%> (+0.11%) |
:arrow_up: |
proteus/TimeIntegration.py | 22.34% <0.00%> (+0.16%) |
:arrow_up: |
proteus/mprans/MoveMesh.py | 86.38% <0.00%> (+0.17%) |
:arrow_up: |
proteus/SpatialTools.py | 49.77% <0.00%> (+0.34%) |
:arrow_up: |
proteus/mprans/RANS2P.py | 87.90% <0.00%> (+0.35%) |
:arrow_up: |
... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4571f06...8f5ae7a. Read the comment docs.
The code coverage increased. Not sure what happened with the other PR. Can we merge and close?
@jhcollins do you have merge privileges? I'm fine with merging.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description
redoing PR #1210