Closed ejtovar closed 3 years ago
Merging #1247 (cf13816) into main (11d8749) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1247 +/- ##
=======================================
Coverage 47.55% 47.56%
=======================================
Files 90 90
Lines 71766 71776 +10
=======================================
+ Hits 34130 34140 +10
Misses 37636 37636
Impacted Files | Coverage Δ | |
---|---|---|
proteus/SWFlow/SWFlowProblem.py | 97.56% <100.00%> (ø) |
|
proteus/SWFlow/models/GN_sw_n.py | 94.00% <100.00%> (ø) |
|
proteus/mprans/GN_SW2DCV.py | 88.74% <100.00%> (+0.05%) |
:arrow_up: |
proteus/mprans/SW2DCV.py | 91.69% <100.00%> (+0.02%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 11d8749...cf13816. Read the comment docs.
@cekees The hashdist linux build is failing due to urllib being failed to download. Is this part of your changes in your latest PR?
@cekees The hashdist linux build is failing due to urllib being failed to download. Is this part of your changes in your latest PR?
Yes, it will fix that. That PR is basically ready to go in, I'm just adjusting how we do coverage checking.
I'll go ahead and do that. I will merge this after we merge your PR.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description
Fixed some bugs in the SWFlow solvers.