Closed jhcollins closed 2 years ago
Looks good. I had to re-enable zoltan for the tests to pass locally, however. It sees to be the default partitioner. I pinged @zhang-alvin to see about getting the scorec conda forge package updated, otherwise I don't think this will run with the version of scorec that is used for the conda environment (both travis builds use conda...). But all tests pass locally.
just the API change I mentioend. I think we should once we get an updated conda package for scorec.
proteus/MeshAdaptPUMI/cMeshAdaptPUMI.cpp: In member function 'int MeshAdaptPUMIDrvr::adaptPUMIMesh(const char*)':
proteus/MeshAdaptPUMI/cMeshAdaptPUMI.cpp:770:14: error: 'makeAdvanced' is not a member of 'ma'
770 | in = ma::makeAdvanced(ma::configureUniformRefine(m));
| ^~~~~~~~~~~~
proteus/MeshAdaptPUMI/cMeshAdaptPUMI.cpp:781:16: error: 'makeAdvanced' is not a member of 'ma'
781 | in = ma::makeAdvanced(ma::configure(m, adaptSize, adaptFrame));
| ^~~~~~~~~~~~
proteus/MeshAdaptPUMI/cMeshAdaptPUMI.cpp:786:16: error: 'makeAdvanced' is not a member of 'ma'
786 | in = ma::makeAdvanced(ma::configure(m, adaptSize));```
pushed conda environment change to match scorec version on #1263
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description