Closed cekees closed 1 year ago
@jhcollins here's a summary:
np.int
. Should just be int
I was hoping to run the richards tests. If they pass on your machine then I will approve.
Yes, they run locally and in the Travis tests running on my fork. Thanks for reviewing!
On your fork, the air-water-vv was removed so will this make command fail the tests prematurely?
test: air-water-vv check
Thanks, I will fix that in the makefile. I'm pushing the responsibility of testing air-water-vv and proteus_tutorial onto those repos so we can keep testing within limits of open source support in Travis.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description