erdc / proteus

A computational methods and simulation toolkit
http://proteustoolkit.org
MIT License
87 stars 55 forks source link

Add fct richards #1277

Closed cekees closed 1 year ago

cekees commented 1 year ago

Mandatory Checklist

Please ensure that the following criteria are met:

As a general rule of thumb, try to follow PEP8 guidelines.

Description

cekees commented 1 year ago

@jhcollins here's a summary:

jhcollins commented 1 year ago

I was hoping to run the richards tests. If they pass on your machine then I will approve.

cekees commented 1 year ago

Yes, they run locally and in the Travis tests running on my fork. Thanks for reviewing!

jhcollins commented 1 year ago

On your fork, the air-water-vv was removed so will this make command fail the tests prematurely?

test: air-water-vv check
cekees commented 1 year ago

Thanks, I will fix that in the makefile. I'm pushing the responsibility of testing air-water-vv and proteus_tutorial onto those repos so we can keep testing within limits of open source support in Travis.