pull numerics and physics defaults from their respective modules

erdc / proteus

A computational methods and simulation toolkit

http://proteustoolkit.org

MIT License

87 stars 55 forks source link

pull numerics and physics defaults from their respective modules #508

Open cekees opened 7 years ago

cekees commented 7 years ago

@tridelat and @alistairbntl it occurs to me that the default values in default_p and default_n should actually come from the modules they are manipulating. e.g. default_n ought to look like

triangleOptions = MeshTools.defaults.triangleOptions

adimako commented 5 years ago

@tridelat has the recent refactoring with @manuel-quezada fixed this?

tridelat commented 5 years ago

@adimako sort of with #818 (not merged yet), which could be related, but it is not modifying those default_n and default_p files as of now, so I don't think this issue is resolved. (#818 gives each model default and relatively "safe" numerical options (or rather options that should work with most test cases if left untouched). Also, #818 is non intrusive, so the usual way to do things is kept intact.)