search

erdelf / AlienRaces

Rimworld mod alien race framework
MIT License
103 stars 69 forks source link

Backstory Bodytype fix #93

Closed RC-3222 closed 1 year ago

RC-3222 commented 1 year ago

Basically learnt that there's such an issue at Elder Scrolls Collaboration Project discord, here's what SirMashedPotato wrote about it image

This small tweak should fix that (tested with races from ESCP, as well as some other random ones from workshop)

erdelf commented 1 year ago

Absolutely not, this causes config errors. If such an issue exists it's not in those lines, as those are explicitly only if there is no bodytype configured.. it's merely a convenience feature for devs that don't want to specify backstories.

kangsangyeon commented 11 months ago

hello. I recently tried to use the backstory's bodytypeFemale property to fix the pawnkind's bodytype, but it didn't work, so I went looking for it and ended up on this page. I'd love to hear more about why you rejected this pull request, if that's okay? From what you've written, I'm not sure what the issue is.

erdelf commented 11 months ago

as I said.. not assigning bodyTypeGlobal causes errors down the line. Not to mention that the "fix" is based on a pretty gross misunderstanding of the code in the first place, where it repeats code for the sake of it.

Largely.. this PR has the only effect of overriding pawn requests with specific bodytypes, and has explicitly nothing to do with the issue they were trying to fix.