search

erdem / django-map-widgets

Highly customizable, intuitive, and user-friendly map widgets for GeoDjango applications.
MIT License
447 stars 119 forks source link

settings: allow disabling streetview #124

Closed mrmikardo closed 3 years ago

mrmikardo commented 3 years ago

Exposes a settings key which hides the Google Street View "peg man", as per: https://developers.google.com/maps/documentation/javascript/streetview#StreetViewMapUsage

This is a useful feature to have -- there are occasions where one wants to prevent end-users from accessing streetview.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 98.964% when pulling 72f4d6f94be6e9850b1b3a9afa2ddaf0d02b78ee on mrmikardo:allow-disabling-streetview into 573c6cab0abffed44dc197f6495f4b75c167a695 on erdem:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 98.964% when pulling 72f4d6f94be6e9850b1b3a9afa2ddaf0d02b78ee on mrmikardo:allow-disabling-streetview into 573c6cab0abffed44dc197f6495f4b75c167a695 on erdem:master.

mrmikardo commented 3 years ago

@erdem hey, is there anything I can do to help out, here? :)

erdem commented 3 years ago

Hey @mrmikardo

Thank you for your contribution. 🙌

I haven't tested your PR changes yet. Managing the street view option with a setting key is definitely a good idea, I am willing to merge the PR. I just need to test the setting in my setup before publishing it in the new version.

I will update the PR during the weekend, sorry for the late response, I am quite busy these days.

erdem commented 3 years ago

@mrmikardo could you update the settings section with the new key in documentation?

https://github.com/erdem/django-map-widgets/blob/master/docs/widgets/point_field_map_widgets.rst#settings

mrmikardo commented 3 years ago

@erdem I've updated the settings docs as requested 👍

mrmikardo commented 3 years ago

Glad to be of help!