integer type error and not setting frequency in fm - Githubissues

erdemarslan / GSMSim

GSM Library for SIMCOM Modules on Arduino.

MIT License

123 stars 55 forks source link

integer type error and not setting frequency in fm #22

Closed zakaria16 closed 4 years ago

zakaria16 commented 4 years ago

the range of fm frequency 875 to 1080 requires 16 bit not 8bit https://github.com/erdemarslan/GSMSim/blob/7a0168f50e4de0f197527aba35748dc5b9958c00/GSMSim.h#L210

Solution is by changing uint8_t to uint16_t

again parameter freq is not used in setting the frequency https://github.com/erdemarslan/GSMSim/blob/7a0168f50e4de0f197527aba35748dc5b9958c00/GSMSim.cpp#L1136 https://github.com/erdemarslan/GSMSim/blob/7a0168f50e4de0f197527aba35748dc5b9958c00/GSMSim.cpp#L1072