search

erdewit / nest_asyncio

Patch asyncio to allow nested event loops
BSD 2-Clause "Simplified" License
693 stars 79 forks source link

1.5.1-1.5.4 is breaking vaex due to #61 #65

Closed maartenbreddels closed 1 year ago

maartenbreddels commented 2 years ago

since #61 out CI breaks (tested locally), but I'm not sure why yet, it seems some tasks don't get executed.

I know this is not (yet) a helpful issue, but in case other people are finding this version range a breaking change, maybe is will help debugging this together.

forna commented 2 years ago

For me the last version of nest_asyncio working is the 1.5.1. 1.5.2 produces an error message: ValueError: Can't patch loop of type <class 'NoneType'> 1.5.3 and .1.5.4 do not execute the async code and I get just timeouts.

erdewit commented 2 years ago

There is not much to go on from these reports, but I suspect it has to do with multithreading. The new v1.5.5 release might offer an improvement in this regard

forna commented 2 years ago

You are right, my application is multithreaded. I can confirm v.1.5.5 fixes the issue, thank you so much.