erdnaxe / galene-stream

Gateway to send UDP, RTMP, SRT or RIST streams to Galène videoconference server.
MIT License
26 stars 5 forks source link

Changes for galene-0.4 #5

Closed jech closed 2 years ago

jech commented 3 years ago

Galene-0.4 will change the protocol slightly. In the case of galene-stream, the only change required will be the following change in the offer message: instead of

labels: whatever

you will need to send

label: "camera"

I will keep this issue updated if there are any further changes to the protocol.

erdnaxe commented 3 years ago

Thank you for the notification. I will apply the fix in a new develop branch then update Galene-stream PyPI package as soon as Galene-0.4 is released.

The field label is one of camera, screenshare or video, and will be matched against the keys sent by the receiver in their request message. -- https://github.com/jech/galene/blob/master/README.PROTOCOL

Are you sure that Galene-stream should put "camera" as a label rather than "screenshare" or "video"?

jech commented 3 years ago

The label is transmitted to the receiver without interpretation by the server. The receiver decides which labels it wishes to receive. The current client receives either everything ("Receive: everything") or just the stream labbelled "screenshare" ("Receive: screenshare").

So I think you may choose anything as long as it's not "screenshare". Perhaps you should pick a new label, specific to galene-stream?

erdnaxe commented 2 years ago

Latest tagged version works with Galene-0.4 (almost 4 months late, oops). Thank you!