Question about seekto offset

erdnaxeli / castblock

Automatically skip sponsor segments and ads in YouTube videos playing on Chromecast.

MIT License

183 stars 20 forks source link

Question about seekto offset #10

Closed stephen304 closed 3 years ago

stephen304 commented 3 years ago

I noticed that there's a 1 second offset to the seek-to command. As far as I can tell the seeking is really accurate and removing the 1 second offset results in better aligned skipping so you don't get the last word of the sponsor read. What would you think of removing that offset? (As long as it doesn't cause #9 )

erdnaxeli commented 3 years ago

Yeah, when I was testing it at the begining it felt like it was skiping a bit of the real video, that's why I added this offset. But you're right, I should remove it.

I will make it configurable, with no offset as default.

erdnaxeli commented 3 years ago

Fixed in 47fd3862e8aaf68c95ffc604c24bcd7723f12baf