search

erdnaxeli / castblock

Automatically skip sponsor segments and ads in YouTube videos playing on Chromecast.
MIT License
182 stars 20 forks source link

Skip native ads #39

Closed johnmurphyme closed 1 year ago

johnmurphyme commented 2 years ago

With the changes I made to go-chromecast, we can now skip ads! https://github.com/vishen/go-chromecast/releases/tag/v0.2.11

I'm currently running this build and it's working well.

erdnaxeli commented 2 years ago

I added a CI job that run a linter and the formater. It's not against you, it just to keep the project clean ^^

Could you merge or rebase on master? I had to split some methods to makes the linter happy and it conflict with your edit.

johnmurphyme commented 2 years ago

I added a CI job that run a linter and the formater. It's not against you, it just to keep the project clean ^^

Could you merge or rebase on master? I had to split some methods to makes the linter happy and it conflict with your edit.

Should be all done now. I hope the rebasing worked.

I also excluded --except Metrics/CyclomaticComplexity from the lint because it was getting caught on that check:

Inspecting 10 files

...F......

src/blocker.cr:53:15
[C] Metrics/CyclomaticComplexity: Cyclomatic complexity too high [14/10]
> private def watch_device(device : Chromecast::Device, continue : Channel(Nil)) : Nil
              ^-----------^

Finished in 68.89 milliseconds
10 inspected, 1 failure
Error: Process completed with exit code 1.
JimboJoe commented 1 year ago

Hello, You guys are doing a great job on castblock and go-chromecast! :+1: Any chance this PR could be merged for the community...? Do you need some tests by the users?

erdnaxeli commented 1 year ago

I am looking at it right now.

erdnaxeli commented 1 year ago

And that's done. The docker images should be pushed in the evening.

JimboJoe commented 1 year ago

Still not there... Was it supposed to be automatic...? 🤔 Thanks!

erdnaxeli commented 1 year ago

Was it supposed to be automatic...?

Not at all :D

I had some troubles with my 2FA authentication on dockerhub, this is fixed now, the images have been pushed!

JimboJoe commented 1 year ago

You rock, thanks! (by the way you can adapt the parameters on the dockerhub overview page 😉)