erdnaxeli / castblock

Automatically skip sponsor segments and ads in YouTube videos playing on Chromecast.
MIT License
182 stars 20 forks source link

Skipping youtube ads not working #49

Closed Pauperkind closed 1 year ago

Pauperkind commented 1 year ago

Hi there! I installed the newest version of castblock on my network today and skipping all the sponsor segments work great! However my ads are still not getting automatically skipped.

I tried the automatic skipping functionality with the erdnaxeli/castblock:latest docker image and building it from scratch with the docker file in this repository, sadly neither worked.

The debug log shows the following:

2022-10-04T14:34:40.621843Z   INFO - castblock.blocker: Found ad, muting audio -- device: "Room TV"
2022-10-04T14:34:40.621859Z  DEBUG - http.client: Performing request -- method: "POST", host: "127.0.0.1", port: 8011, resource: /mute?uuid=5129837129387"
2022-10-04T14:34:41.134321Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:41.142608Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: status parsing Castblock::Chromecast::WatchMessagePayload at line 1, column 1
2022-10-04T14:34:43.019152Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:45.027540Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:47.038907Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:49.047788Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:51.056464Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:52.947145Z  DEBUG - castblock.blocker: Checking for new devices
2022-10-04T14:34:52.947149Z  DEBUG - http.client: Performing request -- method: "GET", host: "127.0.0.1", port: 8011, resource: "/devices"
2022-10-04T14:34:53.067403Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:55.358157Z   INFO - castblock.blocker: Ad ended, unmuting audio -- device: "Room TV"
2022-10-04T14:34:55.358163Z  DEBUG - http.client: Performing request -- method: "POST", host: "127.0.0.1", port: 8011, resource: "/unmute?uuid=5129837129387"
2022-10-04T14:34:55.986431Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:55.986482Z   INFO - castblock.blocker: Ad ended, unmuting audio -- device: "Room TV"
2022-10-04T14:34:55.986487Z  DEBUG - http.client: Performing request -- method: "POST", host: "127.0.0.1", port: 8011, resource: "/unmute?uuid=5129837129387"
2022-10-04T14:34:56.105593Z  DEBUG - castblock.chromecast: Unhandled payload: Missing JSON attribute: status  parsing Castblock::Chromecast::WatchMessagePayload at line 1, column 1
2022-10-04T14:34:57.710912Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:34:59.724593Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:01.737370Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:03.747376Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:05.762166Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:07.771874Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:09.782102Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:12.250322Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"
2022-10-04T14:35:14.267284Z  DEBUG - castblock.blocker: Received message -- application: "YouTube"

In this example, one ad was muted and the other ad was unmuted and didn't automatically get skipped.

Is there also any way to disable the sponsorblock api? I don't mind listening to a sponsor segment but i hate the ads where i have to get my phone and skip the ad.

Thanks in advance!

erdnaxeli commented 1 year ago

Is there also any way to disable the sponsorblock api? I don't mind listening to a sponsor segment but i hate the ads where i have to get my phone and skip the ad.

I never though of that, since the initial feature of this project was to skip sponsor segment :sweat_smile: But this could easily be added.

tried the automatic skipping functionality with the erdnaxeli/castblock:latest docker image and building it from scratch with the docker file in this repository, sadly neither worked.

The latest docker image was only updated this morning so it was expected that it didn't work. But your local build should have worked. I will look at it, thanks for the report.

wwboynton commented 1 year ago

Was this ever added/fixed? The README says:

--skip-ads: enable auto skip during native YouTube ads. These are different from in-video sponsors, and are typically blocked by browser extension ad blockers.

But I don't see this behaviour working as of the latest Docker release, and this issue is still open.

Thanks! <3

stephen304 commented 1 year ago

Was this ever added/fixed? The README says:

--skip-ads: enable auto skip during native YouTube ads. These are different from in-video sponsors, and are typically blocked by browser extension ad blockers.

But I don't see this behaviour working as of the latest Docker release, and this issue is still open.

Thanks! <3

--skip-ads is working for me, however I just noticed after migrating to a new docker host that there's no ENV var support (SKIP_ADS) for this, which made me think it wasn't working.