Remove d3blocks? - Githubissues

erdogant / bnlearn

Python package for Causal Discovery by learning the graphical structure of Bayesian networks. Structure Learning, Parameter Learning, Inferences, Sampling methods.

https://erdogant.github.io/bnlearn

Other

480 stars 46 forks source link

Remove d3blocks? #99

Closed chrisflatley closed 4 months ago

chrisflatley commented 7 months ago

The recently d3blocks introduces some problems:

1.4.10 causes the version check to fail (at least for me) (bug with 1.4.9 > 1.4.10)
d3blocks is GPL-3, which makes this library GPL-3 not MIT.

I wondered if it's necessary to include d3blocks as a formal dependency?

erdogant commented 7 months ago

True. I now removed it from the setup/requirements and added it now as a check when using the interactive plot functionality. Update to the latest version with pip install -U bnlearn