search

eredo / dartson

Dartson is a Dart library that can be used to convert Dart objects into a JSON string.
MIT License
79 stars 29 forks source link

Broader analyzer constraints #35

Closed stevenroose closed 8 years ago

stevenroose commented 8 years ago

I'll test this in a second

stevenroose commented 8 years ago

The dartson_test.dart tests all pass. The transformer_test.dart tests too, but with a warning:

$ dart test/transformer_test.dart 
00:00 +0: read source code from file
00:00 +1: should contain the SimpleClass declaration
00:00 +2: should find a SimpleIdentifier prefix for the dartson import
00:00 +2 ~1: should show the metadata
00:00 +3 ~1: the compiler should contain the SimpleClass
00:00 +4 ~1: fetch entity map from simpleClass
00:00 +5 ~1: build and compile code
Generating code into: /tmp/dartson_Wvpdbm
00:00 +6 ~1: All tests passed!
stevenroose commented 8 years ago

I have a project that uses Angular2 and reflectable. It was not able to find dependencies with dartson 0.2.5, but it could with this edit. (The analyzer version it found was 0.27.3.

Ne4istb commented 8 years ago

I also need it. @eredo what does stop you from merging this PR?

stevenroose commented 8 years ago

You can temporarily fork the repo, merge the PR in your master branch and add a Git dependency to your pubspec file.

However, I would prefer to have this merged as well. @eredo, I would be willing to help maintain this repo if you no longer want to, just add me to the repo and to the pub page.

Ne4istb commented 8 years ago

@stevenroose already did it)) But i guess this fix is needed for other developers as well so it's better to have it published.

eredo commented 8 years ago

I'm sorry for my absence. I'll now continue to support this repository and also add new functionality to dartson.

stevenroose commented 8 years ago

Super, thanks! Don't forget to publish the new version to pub!

On Wed, Oct 5, 2016 at 10:44 PM, Eric Schneller notifications@github.com wrote:

I'm sorry for my absence. I'll now continue to support this repository and also add new functionality to dartson.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eredo/dartson/pull/35#issuecomment-251794014, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0F3BQuG4VFzURdSvjVMaET9lDnmt1fks5qxAw3gaJpZM4Ic556 .

eredo commented 8 years ago

Done! 0.2.6 is available on pub.